From ec1623cbad21c30c9e802641dc7c69d56fc219ce Mon Sep 17 00:00:00 2001 From: Pigway Date: Mon, 5 Oct 2026 08:44:19 +0800 Subject: [PATCH] Keep non-secret Photos account names out of redaction patterns --- pigway_frame_flow/providers/synology_photos.py | 2 +- tests/test_synology_photos.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pigway_frame_flow/providers/synology_photos.py b/pigway_frame_flow/providers/synology_photos.py index 4ccdd8a..95bfab6 100644 --- a/pigway_frame_flow/providers/synology_photos.py +++ b/pigway_frame_flow/providers/synology_photos.py @@ -148,7 +148,7 @@ class SynologyPhotos: def connect(self, payload): password = payload.password.get_secret_value() - self.settings.additional_secrets.extend([payload.username, password]) + self.settings.additional_secrets.append(password) with self.lock: sid = self.request( "SYNO.API.Auth", diff --git a/tests/test_synology_photos.py b/tests/test_synology_photos.py index 8f203a1..efdb210 100644 --- a/tests/test_synology_photos.py +++ b/tests/test_synology_photos.py @@ -18,6 +18,7 @@ def test_connection_stores_session_only(settings, monkeypatch): assert stat.S_IMODE(p.path.stat().st_mode) == 0o600 assert "test-password" not in p.path.read_text() assert p.sid() == "test-session" + assert settings.sanitize({"name": "pigway-frame-flow"})["name"] == "pigway-frame-flow" assert ( settings.sanitize({"message": "test-password test-session"})["message"] == "[REDACTED] [REDACTED]"