fix: separate monitor pause and stabilize RGB edges

app/pigway_pi_control.py

@@ -210,7 +210,9 @@ def load_cfg():
     if c.has_section("services"):
         for label,target in c["services"].items():
             target=target.strip()
-            if target and not target.startswith("#"): watches.append(("service",label.upper(),target))
+            paused=c.getboolean("service_monitor_disabled",label,fallback=False)
+            if target and not target.startswith("#") and not paused:
+                watches.append(("service",label.upper(),target))
     if c.has_section("processes"):
         for label,target in c["processes"].items():
             target=target.strip()
@@ -666,7 +668,8 @@ class DisplayController:
             }
 
     def _rgb_worker(self):
-        previous_error=None; applied_mode="OFF"; applied_flash=False; animation_started=time.monotonic()
+        previous_error=None; applied_mode="OFF"; applied_flash=False
+        flash_on=None; animation_started=time.monotonic()
         while not self.stop_event.is_set():
             try:
                 with self.lock: wanted_mode=self.current_rgb_mode
@@ -683,6 +686,7 @@ class DisplayController:
                         else: raise ValueError(f"unsupported RGB mode: {wanted_mode}")
                     log("INFO","RGB_MODE",old=applied_mode,new=wanted_mode)
                     applied_mode=wanted_mode; animation_started=time.monotonic()
+                    flash_on=True if wanted_mode.endswith("_FLASH") else None
                 applied_flash=applied_mode.endswith("_FLASH")
                 if applied_flash:
                     elapsed_ms=(time.monotonic()-animation_started)*1000.0
@@ -691,10 +695,12 @@ class DisplayController:
                     elif "_CRITICAL_" in applied_mode: on_ms,off_ms=CRITICAL_FLASH
                     else: on_ms,off_ms=WARNING_FLASH
                     on=elapsed_ms%(on_ms+off_ms)<on_ms
-                    with bus_lock:
-                        if applied_mode=="NORMAL_FLASH":
-                            rgb_static(NORMAL_COLOR,"normal_flash_on") if on else rgb_off()
-                        else: rgb_flash(applied_mode,on)
+                    if on!=flash_on:
+                        with bus_lock:
+                            if applied_mode=="NORMAL_FLASH":
+                                rgb_static(NORMAL_COLOR,"normal_flash_on") if on else rgb_off()
+                            else: rgb_flash(applied_mode,on)
+                        flash_on=on
                 if previous_error is not None: log("INFO","RGB_RECOVERED")
                 previous_error=None
             except Exception as e:

app/pigway_pi_control_api.py

@@ -145,19 +145,23 @@ def service_inventory():
             item.update({"active":parts[2],"description":parts[4] if len(parts)>4 else ""})
     for name,target in monitored.values():
         item=units.setdefault(target,{"unit":target,"enabled":"not-found","active":"inactive","description":""})
-        item.update({"monitored":True,"monitor_name":name.upper(),"note":notes.get(name,"")})
+        paused=cfg.getboolean("service_monitor_disabled",name,fallback=False)
+        item.update({"monitored":True,"paused":paused,"monitor_name":name.upper(),"note":notes.get(name,"")})
     for item in units.values():
-        item.setdefault("monitored",False); item.setdefault("monitor_name",""); item.setdefault("note","")
+        item.setdefault("monitored",False); item.setdefault("paused",False)
+        item.setdefault("monitor_name",""); item.setdefault("note","")
         item["protected"]=item["unit"] in PROTECTED_UNITS
     return sorted(units.values(),key=lambda x:(not x["monitored"],x["unit"]))
 
 def edit_service_monitor(operation,name,target,note="",previous_name=""):
-    if operation not in {"save","delete"}: raise ValueError("operation must be save or delete")
+    if operation not in {"save","delete","pause","resume"}: raise ValueError("invalid monitor operation")
     if not NAME_RE.fullmatch(name): raise ValueError("invalid monitor name")
     if not UNIT_RE.fullmatch(target): raise ValueError("invalid systemd service name")
     if len(note)>120 or any(c in note for c in "\r\n\x00"): raise ValueError("invalid note")
     if previous_name and not NAME_RE.fullmatch(previous_name): raise ValueError("invalid previous monitor name")
     cfg=load_cfg(); old_target=cfg.get("services",name,fallback=None)
+    previous=previous_name or name
+    was_paused=cfg.getboolean("service_monitor_disabled",previous,fallback=False)
     text=CFG.read_text()
     def change(section,key,value):
         nonlocal text
@@ -176,11 +180,16 @@ def edit_service_monitor(operation,name,target,note="",previous_name=""):
             text=text[:end].rstrip()+f"\n{key} = {value}\n\n"+text[end:].lstrip("\n")
     if operation=="delete":
         if old_target is None: raise ValueError("monitor not found")
-        change("services",name,None); change("service_notes",name,None)
+        change("services",name,None); change("service_notes",name,None); change("service_monitor_disabled",name,None)
+    elif operation in {"pause","resume"}:
+        if old_target is None: raise ValueError("monitor not found")
+        change("service_monitor_disabled",name,"true" if operation=="pause" else None)
     else:
         if previous_name and previous_name.lower()!=name.lower():
             change("services",previous_name,None); change("service_notes",previous_name,None)
+            change("service_monitor_disabled",previous_name,None)
         change("services",name,target); change("service_notes",name,note or None)
+        if was_paused: change("service_monitor_disabled",name,"true")
     parsed=configparser.ConfigParser(); parsed.read_string(text)
     backup=CFG.with_name(f"{CFG.name}.bak.api-{time.strftime('%Y%m%d-%H%M%S')}")
     shutil.copy2(CFG,backup)